feat: rename createWorkerFixture to createNetworkFixture
#8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
createWorkerFixture to createNetworkFixturecreateWorkerFixture to createNetworkFixture
4a63f0b to
0dd8288
Compare
Released: v0.4.0 🎉This has been released in v0.4.0! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the fixture creating API to
createNetworkFixture. The reasoning behind this is that "worker" is a generic term that also has a different meaning in Playwright (as in "test worker"). The connection with the worker fromsetupWorker()in MSW is extremely weak here.Instead, I propose to refer to the created fixture as the "network fixture". That describes precisely what that fixture does—controls the network in your test.