-
Notifications
You must be signed in to change notification settings - Fork 76
Created runtests.py using pytest and integrated into setup.py (#168) #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As a side note, it might be a good idea to have a virtual environment active when trying this. I don't know yet, if it installs something when If someone has more experience with it, please enlighten me. Thx. |
setup.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you have generated runtests.py
via py.test? If that is the case we should also add the generation code to the repository. If we take this approach I assume we can also delete run_tests.sh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we might want to follow that: http://pytest.org/latest/goodpractises.html#integration-with-setuptools-test-commands
I followed the guide laid out in the link @whimboo posted earlier (http://pytest.org/latest/goodpractises.html#integration-with-setuptools-test-commands). I think it should be noted that the use of a venv is advised right at the beginning of the guide (not sure if it is still applicable for this case). Should I write a script that calls Also, how applicable to us is the section on Continuous Integration (http://pytest.org/latest/goodpractises.html#use-tox-and-continuous-integration-servers) |
I don't understand why we're introducing pytest here... |
Here's some documentation I found on running a unittest suite under setuptools: http://pythonhosted.org/setuptools/setuptools.html#test-build-package-and-run-a-unittest-suite as we already use unitttest, it shouldn't be too difficult to implement this. I don't think we need to introduce py.test, which is an alternative to unittest. That said, I question how useful this even is... |
@davehunt some alternative for pytest.parametrize would be good for our 2013/11/26 Dave Hunt [email protected]
jarek@reijutsu: |
Shall we get this issue closed or implement an alternative? I would suggest we close it. |
I would close it. It does not add anything to our existing setup |
Alright. So lets do it then. Thanks! |
Here I used py.test to address issue #168
see also http://pytest.org/latest/goodpractises.html as initially pointed out by @whimboo