Show found candidate builds when build number is given (#148) #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review. Thx! |
mozdownload/scraper.py
Outdated
There was a problem hiding this comment.
Instead of having this inside both the if and else blocks, we could just move it ahead of the logic.
There was a problem hiding this comment.
Man, I must have really been on autopilot that day. Not thinking whatsoever. My other PR was rubbish, too, like that.
|
Thanks for reviewing it. This should do the trick now. |
There was a problem hiding this comment.
I think we should output which of those builds we have chosen. Otherwise it's confusing.
There was a problem hiding this comment.
Given that the daily scraper doesn't do this either we should handle that in another issue.
There was a problem hiding this comment.
And which is #149 :) Sorry.
|
This looks good. I landed this on master as: c0a680e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull address issue #148
This was a rather simple fix.
self.get_build_info_for_versionwas just not called in the if option where a build-number had to be specified.