Add pylama config to tox.ini (#418) #419
Conversation
tox.ini
Outdated
| [pylama:pylint] | ||
| max_line_length = 100 | ||
| disable = R | ||
|
|
There was a problem hiding this comment.
Lets not put those configurations into the tox.ini bug use setup.cfg for it. See https://pylama.readthedocs.io/en/latest/#configuration-files.
Also I would prefer to have a general pylama section and not specific ones for each tool used. Does [pylama] not work? Also what is disable = R? Is that really something we need?
There was a problem hiding this comment.
You are absolutely right. I moved it to setup.cfg like you suggested.
|
Looks like this PR is blocked on issue #420 now. |
| max_line_length = 100 | ||
|
|
||
| [pylama:pylint] | ||
| max_line_length = 100 |
There was a problem hiding this comment.
Cannot we define a single pylama section with global settings? I feel it weird that we have to do it for each individual checker.
There was a problem hiding this comment.
I tried that first, but it would cause pycodestyle failures on line_length
With the way I did it, this did not occur...
There was a problem hiding this comment.
Ok, looks like it is indeed the way to go. It looks fine to me.
|
@whimboo Do you have any idea what is going on with all these errors on tests? Everytime, we try to fix one, another one jumps out... This connection error I am experiencing on my laptop, too. It cannot come from this PR, since I am only changing some lines in setup.cfg and the error is thrown in |
|
Johannes please see my latest comment on this PR. This is basically blocked on issue #420 which we have to get fixed first. |
951df87 to
385903c
Compare
|
Except OS X which is still running, all other platforms have passing tests now. So I would say lets get this PR merged! |
The PR addresses issue #418
I only added config data to tox.ini as described in the pylama docs ( https://github.com/klen/pylama#id16 )
I could not fully change it, so let's see if the same error persists in appveyor as before.