Change branch=mozilla-central to comm-central #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failures in the test runs seem to be associated with issue #404 |
|
Right. So once the other PR got fixed lets re-run those tests. |
|
Whereby there is no need to run the tests again, actually. But we have to wait with the landing given that it would break master. |
8b3e2fd to
46983ed
Compare
|
@whimboo OK, I think my rebase worked... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #238 .
It's been awhile since I used git so I am quite rusty so I thought I'll take an easy one ;)
@whimboo Could you please review?
Thanks :)