Remove Bluebird and replace callbacks with async/await #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackthornYugen
requested changes
Aug 24, 2022
Member
BlackthornYugen
left a comment
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rtritto)
lib/routes/database.js line 60 at r1 (raw file):
}); // await ndb.dropCollection('delete_me').then(() => {
Can we delete the commented code?
Member
Author
|
I don't know, there should be some reason for that code. |
BlackthornYugen
approved these changes
Aug 24, 2022
Member
BlackthornYugen
left a comment
There was a problem hiding this comment.
In general I'd try to avoid keeping commented code arround but since it was there before your change I guess it's okay. 😛
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rtritto)
BlackthornYugen
approved these changes
Aug 24, 2022
Member
BlackthornYugen
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @rtritto)
Mamoona-Ghania
pushed a commit
to FaizaAslam013/Devops-Mids-Exam
that referenced
this pull request
Dec 13, 2025
Remove Bluebird and replace callbacks with async/await
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is
Remove callbacks for #857