-
Notifications
You must be signed in to change notification settings - Fork 1k
Improve find and aggregate #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm following your commits. Looks great, thanks! |
|
You removed a "collection not found" error handling, is it handled somewhere else? |
|
The exsitence check of a collection is here: if (!mongo.collections[req.dbName].includes(id)) {
req.session.error = 'Collection not found!';
return res.redirect(res.locals.baseHref + 'db/' + req.dbName);
}I think that if a collection exists, it also have the stats and, for a collection not found, there's a redirect in router (/lib/routes/collection.js isn't called). |
shakaran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @rtritto)
|
Hi rtritto! Thanks for all the fixes these last days. Amazing work, really appreciate it! Everything seems to work now. (Opening documents with Base64 BinaryIDs, Opening collections in Mongo 4.X and Opening rather large collections) Regarding: This works, i can open the large collections now. It's just slow as heck, i remember with a version of mongo-express a few months back (1.0.0-alpha4 IIRC) it was rather quick. To open or change page in a collection of 5.666.031 documents it takes about 50 seconds in the most recent build. |
@dariowrk the 1.0.0-alpha4 use the count that is deprecated. Under the hood, |
* Improve find and aggregate * Fix query of countDocuments and split pipelines of aggregates
This change is
Changes
$facetis moved only to complex pipeline (Array pipeline) and not to default query (that will fix Cannot open collections on MongoDB Version 4.2.22 #1082).