fix: update blacklist handling to return instead of throwing an error #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could someone take a look at this please? |
icebob
requested changes
Apr 14, 2025
| if (alias.action && route.hasBlacklist) { | ||
| if (this.checkBlacklist(route, alias.action)) { | ||
| this.logger.debug(` The '${alias.action}' action is in the blacklist!`); | ||
| throw new ServiceNotFoundError({ action: alias.action }); |
Member
There was a problem hiding this comment.
Here you should keep the error throwing because we do it in whitelist as well.
src/index.js
Outdated
| // Blacklist check | ||
| if (route.hasBlacklist) { | ||
| if (this.checkBlacklist(route, action.name)) { | ||
| this.logger.debug( |
Member
There was a problem hiding this comment.
Please remove the log, no log message in whitelist as well.
Author
|
sory @icebob... took me agfain forever to continue here... too much stuff going on at work. |
Author
|
ping. @icebob |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently introduced the Blacklist feature (different username @jappyjan , same person :D but this time using my work account ^^)
Tuns out that i accidentally introduced a bug which causes the moleculer broker/service to kill the process instead of just not executing an action.
This PR fixes it by replacing the throwing of an error when a service is blacklisted with a simple return like we do it for the whitelist too.