Disallow Dot Character in Resource Alias for Alpha/Alphanumeric Restrictions #16774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove dot in final segment when restriction is the preset 'alpha' or 'alphanumeric'
Code quality fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Replaces dot characters in alias with the
friendly_alias_word_delimitercharacter whenfriendly_alias_restrict_charssystem setting is alpha or alphanumeric.Note that I chose not to just remove the dot, as the meaning of an alias in certain scenarios would be made inaccurate (or at least misleading) by doing so. Consider this fictitious example:
pagetitle: In 2024, The Post Lost 7.6 Percent of Its Readership
alias (dot removed): in-2024-the-post-lost-76-percent-of-its-readership
Why is it needed?
By definition, it makes no sense to allow any character not defined by these two rules.
How to test
Change the
friendly_alias_restrict_charssetting and verify that, when alpha or alphanumeric is chosen, dots in a friendly url Resource alias are replaced by the preferred delimiter.Related issue(s)/PR(s)
Resolves #16665