Skip to content

Conversation

@soraros
Copy link
Contributor

@soraros soraros commented Oct 30, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 30, 2025 17:35
@soraros soraros requested a review from a team as a code owner October 30, 2025 17:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the vectorize function by removing unnecessary UInt type conversions when calling align_down. The changes align the first vectorize overload with the second overload, which already uses Int types directly.

  • Removed unnecessary UInt() conversions for size parameter in align_down calls
  • Made the type usage consistent between both vectorize overloads

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@soraros soraros force-pushed the remove-implicit-conversion-range branch from 56cdbb1 to be0d011 Compare October 30, 2025 17:41
@soraros soraros changed the title [stdlib] Remove unneccessary call to UInt to fix implicit conversion later in range [stdlib] Remove unneccessary call to UInt to avoid implicit conversion later in range Oct 30, 2025
@soraros soraros force-pushed the remove-implicit-conversion-range branch from be0d011 to b41f819 Compare October 30, 2025 20:17
Copy link
Contributor

@laszlokindrat laszlokindrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@soraros soraros marked this pull request as draft October 31, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants