fix(mobile_take_screenshot): fix MCP client compatibility and response format #193
+3
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e format - Change from server.tool() to tool() helper function for better MCP client compatibility - Simplify return format from complex object to Data URL string format - Improve error handling with ActionableError for consistency Fixes mobile_take_screenshot function returning empty responses to MCP clients.
|
@aRaikoFunakami thanks for the PR. which agents caused problems with this? we're testing this thoroughly on gemini, claude code and codex. But certainly another agent causes issues, I'd like to add it to our test suite. 🙏 |
|
@aRaikoFunakami yo. I'm trying to reproduce the issue. where did you see that the current code fails? under which model and agent? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mobile_take_screenshot MCP client compatibility
Problem
mobile_take_screenshotwas returning empty responses to MCP clients, making it unusable.Root Cause
The tool was using
server.tool()directly instead of thetool()helper function used by all other tools.Solution
server.tool()totool()helperActionableErrorfor consistent error handlingResult