Improve error message and give suggestion on how to resolve problem when mocking a sealed interface or abstract class. #3552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen mocking a sealed interface or abstract class.
TimvdLippe
approved these changes
Dec 17, 2024
Contributor
TimvdLippe
left a comment
There was a problem hiding this comment.
Looks good to me. Seems like we have duplicate code between the inline mockmakers. Shall we deduplicate that?
Member
Author
|
Can you point to where? If it's the same checks, certainly, to make them behave consistent. |
Contributor
Contributor
Contributor
Member
Author
|
I was confused myself, but thought I just never created a PR. |
Contributor
|
Given that 7c277ac exists on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the error message of sealed types to suggest mocking a non-abstract subclass which allows to use a mock by type substitution.