Skip to content

remove extraGlobals() #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2019
Merged

remove extraGlobals() #3970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 1 addition & 25 deletions lib/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ function Runner(suite, delay) {
});
this._defaultGrep = /.*/;
this.grep(this._defaultGrep);
this.globals(this.globalProps().concat(extraGlobals()));
this.globals(this.globalProps());
}

/**
Expand Down Expand Up @@ -1016,30 +1016,6 @@ function thrown2Error(err) {
);
}

/**
* Array of globals dependent on the environment.
*
* @return {Array}
* @deprecated
* @todo remove; long since unsupported
* @private
*/
function extraGlobals() {
if (typeof process === 'object' && typeof process.version === 'string') {
var parts = process.version.split('.');
var nodeVersion = parts.reduce(function(a, v) {
return (a << 8) | v;
});

// 'errno' was renamed to process._errno in v0.9.11.
if (nodeVersion < 0x00090b) {
return ['errno'];
}
}

return [];
}

Runner.constants = constants;

/**
Expand Down