3370: Add support for comment lines in "mocha.opts" #3375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified code to strip comment lines, those beginning with a hash character ('#'), from "mocha.opts"
prior to processing its contents.
Fixes mochajs#3370
4547268 to
7613521
Compare
outsideris
reviewed
May 5, 2018
Contributor
outsideris
left a comment
There was a problem hiding this comment.
Describing comments on docs will be great.
Added information on file content, noting support for comment/blank lines.
outsideris
approved these changes
May 6, 2018
Contributor
Author
|
@boneskull ping |
wopian
referenced
this pull request
in wopian/agc-assembly
May 20, 2018
This Pull Request updates dependency [mocha](https://github.com/mochajs/mocha) from `~5.1.0` to `~5.2.0` <details> <summary>Release Notes</summary> ### [`v5.2.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#​520--2018-05-18) [Compare Source](mochajs/mocha@v5.1.1...v5.2.0) #### 🎉 Enhancements - [#​3375]: Add support for comments in `mocha.opts` ([@​plroebuck]) #### 🐛 Fixes - [#​3346]: Exit correctly from `before` hooks when using `--bail` ([@​outsideris]) #### 📖 Documentation - [#​3328]: Mocha-flavored [API docs](https://mochajs.org/api/)! ([@​Munter]) #### 🔩 Other - [#​3330]: Use `Buffer.from()` ([@​harrysarson]) - [#​3295]: Remove redundant folder ([@​DavNej]) - [#​3356](`https://github.com/mochajs/mocha/pull/3356`): Refactoring ([@​plroebuck]) [#​3375]: `https://github.com/mochajs/mocha/pull/3375` [#​3346]: `https://github.com/mochajs/mocha/pull/3346` [#​3328]: `https://github.com/mochajs/mocha/pull/3328` [#​3330]: `https://github.com/mochajs/mocha/pull/3330` [#​3295]: `https://github.com/mochajs/mocha/pull/3295` [@​plroebuck]: https://github.com/plroebuck [@​harrysarson]: https://github.com/harrysarson [@​outsideris]: https://github.com/outsideris [@​Munter]: https://github.com/Munter --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
This was referenced Sep 22, 2018
This was referenced Oct 4, 2018
This was referenced Oct 25, 2018
This was referenced Nov 1, 2018
This was referenced Nov 9, 2018
Closed
This was referenced Dec 1, 2018
This was referenced Dec 8, 2018
This was referenced Dec 23, 2018
This was referenced Mar 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Modified code to strip comment lines [lines beginning with a hash character ('#')] from "mocha.opts" prior to processing its contents. Inline comments are not supported.
Alternate Designs
See related issues in #3370.
One used JS comments '//', but most everyone agreed hash '#' was more fitting.
Others got bogged down attempting to figure out how to support inline comments.
Why should this be in core?
N/A
Benefits
Possible Drawbacks
None to knowledge
Applicable issues
Fixes #3370
(minor/patch release)? yes
This is an enhancement with no impact on production code; could go with either.