Tidy up dune files #247
Merged
Tidy up dune files #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emillon
commented
Jun 18, 2021
| (public_name github) | ||
| (wrapped false) | ||
| (modules_without_implementation github_s) | ||
| ;; 27 and 32 should be enabled once |
Contributor
Author
There was a problem hiding this comment.
We can also set [@@@ ocaml.warning "-27-32"] for a less intrusive change.
Member
|
Looks good to me, just failing on the 4.12 builds as expected. |
Member
|
Thanks! |
tmcgilchrist
added a commit
to tmcgilchrist/opam-repository
that referenced
this pull request
Jul 13, 2021
CHANGES: - Fixes to odoc warnings and cohttp dependencies (@Aaylor mirage/ocaml-github#244) - Support for 4.12 and fixing recent compiler warnings (@tmcgilchrist mirage/ocaml-github#246 mirage/ocaml-github#252 and @emillon mirage/ocaml-github#250 mirage/ocaml-github#247 mirage/ocaml-github#251) - Add a new package `github-data` which contains just the serialisation logic without a dependency on the web stack (mirage/ocaml-github#248 @emillon) - Add Github checks API support (mirage/ocaml-github#249 @tmcgilchrist)
tmcgilchrist
added a commit
to tmcgilchrist/opam-repository
that referenced
this pull request
Jul 21, 2021
CHANGES: - Fixes to odoc warnings and cohttp dependencies (@Aaylor mirage/ocaml-github#244) - Support cohttp 4.0. (@tmcgilchrist mirage/ocaml-github#257) - Support for 4.12 and fixing recent compiler warnings (@tmcgilchrist mirage/ocaml-github#246 mirage/ocaml-github#252 and @emillon mirage/ocaml-github#250 mirage/ocaml-github#247 mirage/ocaml-github#251) - Add a new package `github-data` which contains just the serialisation logic without a dependency on the web stack (mirage/ocaml-github#248 @emillon) - Add Github checks API support (mirage/ocaml-github#249 @tmcgilchrist) - Label field missing in branch refs for ghost (@dra27 and @tmcgilchrist mirage/ocaml-github#256) - Get all commits for user/repo (@Stevendeo mirage/ocaml-github#245)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of #246:
There was a link to an old dune issue but it seems that these were hiding some
problems.
To the best of my knowledge, it is best practice to let dune deal with flags.
Small improvements by using shortcuts allowed by dune.