Disable source map register when generating the lib/index.js bundle
#248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, ncc with source map support generates a file called `sourcemap-register.cjs` that is imported from the main bundle. I am not familiar with the purpose of this extra implementation file, but it seems to me that this might be a compatibility layer meant for older versions of Node that did not have full support for source maps. Apparently, I never checked this extra file to version control and it caused import problems in the v3.3 release. Since this action runs under Node 20 that has full support for source maps, I'm guessing that this compatibility later isn't needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, ncc with source map support generates a file called
sourcemap-register.cjsthat is imported from the main bundle. I am not familiar with the purpose of this extra implementation file, but it seems to me that this might be a compatibility layer meant for older versions of Node that did not have full support for source maps. Apparently, I never checked this extra file to version control and it caused import problems in the v3.3 release.Since this action runs under Node 20 that has full support for source maps, I'm guessing that this compatibility later isn't needed anymore.
Fixes #245