Skip to content

Lifecycle expiration date, WithEndpoint, WithSSL issues cause functional tests to fail #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 21, 2023
Merged

Lifecycle expiration date, WithEndpoint, WithSSL issues cause functional tests to fail #844

merged 9 commits into from
Oct 21, 2023

Conversation

@ebozduman
Copy link
Collaborator

@ebozduman ebozduman commented Aug 20, 2023 •
edited
Loading

Fixes the functional tests, part of the CI and merge process, failures.

The following issues are addressed :

  • The life cycle expiration date is supposed to be replaced to the next day's midnight before the request is sent to the s3 server and the existing code was not doing it.
  • WithSSl(secure=false) is ignored
  • 3 versions of WithEndpoint() methods set endpoint either incorrectly and/or they were inconsistent
  • BucketExistsAsync method exception handling and responseResult interpretation were not correct.

@ebozduman
Copy link
Collaborator Author

ebozduman commented Aug 20, 2023 •
edited
Loading

@tvdias and others,
Sorry for the mix up.
Not sure how the other commits (@tvdias and others) made into my PR.
I was reviewing and testing @tvdias PR #839 and I must have created this PR's branch on there instead of master.
Will be cleaning up those commits.

@ebozduman ebozduman force-pushed the inorrect-Lifecycle-expiration branch from 0648b6b to c87b880 Compare August 21, 2023 09:30
@martijn00
Copy link
Contributor

martijn00 commented Aug 24, 2023

@ebozduman can you look at the tests?

@ebozduman
Copy link
Collaborator Author

ebozduman commented Aug 24, 2023

Yes... already working on it.

@ebozduman ebozduman mentioned this pull request Aug 26, 2023
Merged
@ebozduman ebozduman force-pushed the inorrect-Lifecycle-expiration branch from c87b880 to ffeec15 Compare August 29, 2023 07:53
@ebozduman
Copy link
Collaborator Author

ebozduman commented Aug 29, 2023

My fix works in my local setup and all 6 bucket lifecycle tests pass.
In the build testing though, all but BucketLifecycleAsync_Test1.2 passes.
It looks like there is yet another problem still there and it is again another transient issue.
I'll be looking into this new problem.

@ebozduman ebozduman force-pushed the inorrect-Lifecycle-expiration branch from b46797b to 3c05445 Compare September 6, 2023 14:50
@ebozduman ebozduman force-pushed the inorrect-Lifecycle-expiration branch from 3c05445 to e61620e Compare October 13, 2023 09:17
harshavardhana
harshavardhana previously approved these changes Oct 17, 2023
View reviewed changes
@harshavardhana
Copy link
Member

harshavardhana commented Oct 17, 2023

PTAL CI failures @ebozduman

@ebozduman
Copy link
Collaborator Author

ebozduman commented Oct 17, 2023

Yes. I am looking into it.

Thank you.

@ebozduman ebozduman force-pushed the inorrect-Lifecycle-expiration branch from 91b68b3 to 46529db Compare October 19, 2023 04:44
@ebozduman ebozduman mentioned this pull request Oct 19, 2023
Closed
@ebozduman
Copy link
Collaborator Author

ebozduman commented Oct 19, 2023 •
edited
Loading

This PR also addresses the issues, #884 (dup of #878), #887 (duplicate of #873), #837 and #847

@ebozduman ebozduman changed the title Lifecycle expiration date calculation is incorrect Lifecycle expiration date, WithEndpoint, WithSSL issues cause functional tests to fail Oct 21, 2023
@ebozduman ebozduman mentioned this pull request Oct 21, 2023
Closed
@harshavardhana harshavardhana merged commit 3a38f1e into minio:master Oct 21, 2023
This was referenced Oct 21, 2023
Closed
Closed
Closed
This was referenced Nov 2, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

+1 more reviewer

@martijn00 martijn00 martijn00 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ebozduman @martijn00 @harshavardhana