Skip to content

feat: Add import reader for Parquet #29618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sre-ci-robot merged 8 commits into from
Jan 7, 2024
Merged

feat: Add import reader for Parquet #29618

sre-ci-robot merged 8 commits into from
Jan 7, 2024

Conversation

@bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented Jan 2, 2024

This PR implements a Parquet reader for import.

issue: #28521

@bigsheeper bigsheeper mentioned this pull request Jan 2, 2024
Closed
12 tasks
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Jan 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jan 2, 2024
@mergify
Copy link
Contributor

mergify bot commented Jan 2, 2024

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

xiaocai2333
xiaocai2333 reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@xiaocai2333 xiaocai2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2024

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot removed the lgtm label Jan 4, 2024
@bigsheeper
Copy link
Contributor Author

bigsheeper commented Jan 4, 2024

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

bigsheeper commented Jan 5, 2024

/run-cpu-e2e

@yellow-shine
Copy link
Collaborator

yellow-shine commented Jan 5, 2024

rerun ut

@bigsheeper
Copy link
Contributor Author

bigsheeper commented Jan 5, 2024

/run-cpu-e2e

@bigsheeper
Copy link
Contributor Author

bigsheeper commented Jan 5, 2024

rerun ut

@bigsheeper
Copy link
Contributor Author

bigsheeper commented Jan 5, 2024

/run-cpu-e2e

@codecov
Copy link

codecov bot commented Jan 5, 2024 •
edited
Loading

Codecov Report

Attention: 781 lines in your changes are missing coverage. Please review.

Comparison is base (3561586) 80.82% compared to head (56bf89e) 83.26%.
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #29618      +/-   ##
==========================================
+ Coverage   80.82%   83.26%   +2.43%     
==========================================
  Files         926      691     -235     
  Lines      127767   110309   -17458     
==========================================
- Hits       103271    91849   -11422     
+ Misses      21145    15024    -6121     
- Partials     3351     3436      +85
Files Coverage Δ
internal/allocator/cached_allocator.go 73.04% <100.00%> (ø)
internal/datacoord/channel_manager.go 77.61% <100.00%> (ø)
internal/datacoord/compaction_trigger.go 85.08% <100.00%> (ø)
internal/datacoord/segment_manager.go 88.54% <100.00%> (+1.01%) ⬆️
internal/datanode/event_manager.go 76.34% <100.00%> (ø)
internal/indexnode/indexnode.go 82.12% <100.00%> (ø)
internal/mq/mqimpl/rocksmq/client/client_impl.go 82.90% <100.00%> (ø)
internal/mq/mqimpl/rocksmq/client/consumer_impl.go 96.29% <100.00%> (ø)
internal/mq/mqimpl/rocksmq/server/rocksmq_impl.go 83.41% <100.00%> (ø)
...rnal/mq/mqimpl/rocksmq/server/rocksmq_retention.go 76.72% <100.00%> (ø)
... and 54 more

... and 259 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Jan 5, 2024

/approve

@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bigsheeper
Copy link
Contributor Author

bigsheeper commented Jan 5, 2024

/run-cpu-e2e

@bigsheeper
Copy link
Contributor Author

bigsheeper commented Jan 6, 2024

rerun ut

1 similar comment
@bigsheeper
Copy link
Contributor Author

bigsheeper commented Jan 6, 2024

rerun ut

@czs007
Copy link
Collaborator

czs007 commented Jan 7, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 156a0dd into milvus-io:master Jan 7, 2024
@mergify
Copy link
Contributor

mergify bot commented Apr 24, 2024

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaocai2333 xiaocai2333 xiaocai2333 left review comments

@sunby sunby Awaiting requested review from sunby

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@xiaocai2333 xiaocai2333

@czs007 czs007

Labels

approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/XXL Denotes a PR that changes 1000+ lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bigsheeper @yellow-shine @czs007 @sre-ci-robot @xiaocai2333