gvfs-helper: handle pack-file after single POST request #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffhostetler
approved these changes
Nov 11, 2019
jeffhostetler
left a comment
There was a problem hiding this comment.
either way is fine.
thanks for fixing this!
wilbaker
approved these changes
Nov 11, 2019
ba296c3 to
2132f6c
Compare
If our POST request includes a commit ID, then the the remote will send a pack-file containing the commit and all trees reachable from its root tree. With the current implementation, this causes a failure since we call install_loose() when asking for one object. Modify the condition to check for install_pack() when the response type changes. Also, create a tempfile for the pack-file download or else we will have problems! Signed-off-by: Derrick Stolee <[email protected]>
2132f6c to
1deef24
Compare
derrickstolee
added a commit
to microsoft/scalar
that referenced
this pull request
Nov 13, 2019
We still have code for the `gvfs/objects` endpoint due to downloading the initial commit at clone time. We can instead ask the `git gvfs-helper` to make a POST request on that commit, which reduces our code significantly. Also remove size endpoint details while we are here. See microsoft/git#221 for the Git changes required.
derrickstolee
added a commit
that referenced
this pull request
Dec 30, 2019
…OST request If our POST request includes a commit ID, then the the remote will send a pack-file containing the commit and all trees reachable from its root tree. With the current implementation, this causes a failure since we call install_loose() when asking for one object. Modify the condition to check for install_pack() when the response type changes.
derrickstolee
added a commit
that referenced
this pull request
Jan 14, 2020
…OST request If our POST request includes a commit ID, then the the remote will send a pack-file containing the commit and all trees reachable from its root tree. With the current implementation, this causes a failure since we call install_loose() when asking for one object. Modify the condition to check for install_pack() when the response type changes.
derrickstolee
added a commit
that referenced
this pull request
Feb 21, 2020
…OST request If our POST request includes a commit ID, then the the remote will send a pack-file containing the commit and all trees reachable from its root tree. With the current implementation, this causes a failure since we call install_loose() when asking for one object. Modify the condition to check for install_pack() when the response type changes.
derrickstolee
added a commit
that referenced
this pull request
Mar 17, 2020
…OST request If our POST request includes a commit ID, then the the remote will send a pack-file containing the commit and all trees reachable from its root tree. With the current implementation, this causes a failure since we call install_loose() when asking for one object. Modify the condition to check for install_pack() when the response type changes.
derrickstolee
added a commit
that referenced
this pull request
Mar 23, 2020
…OST request If our POST request includes a commit ID, then the the remote will send a pack-file containing the commit and all trees reachable from its root tree. With the current implementation, this causes a failure since we call install_loose() when asking for one object. Modify the condition to check for install_pack() when the response type changes.
dscho
pushed a commit
that referenced
this pull request
May 20, 2020
…OST request If our POST request includes a commit ID, then the the remote will send a pack-file containing the commit and all trees reachable from its root tree. With the current implementation, this causes a failure since we call install_loose() when asking for one object. Modify the condition to check for install_pack() when the response type changes.
dscho
pushed a commit
that referenced
this pull request
May 20, 2020
…OST request If our POST request includes a commit ID, then the the remote will send a pack-file containing the commit and all trees reachable from its root tree. With the current implementation, this causes a failure since we call install_loose() when asking for one object. Modify the condition to check for install_pack() when the response type changes.
derrickstolee
pushed a commit
that referenced
this pull request
Jun 1, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Jul 20, 2020
dscho
pushed a commit
that referenced
this pull request
Jan 1, 2025
dscho
pushed a commit
that referenced
this pull request
Jan 1, 2025
dscho
pushed a commit
that referenced
this pull request
Feb 10, 2025
dscho
pushed a commit
that referenced
this pull request
Feb 27, 2025
dscho
pushed a commit
that referenced
this pull request
Mar 5, 2025
dscho
pushed a commit
that referenced
this pull request
Mar 5, 2025
mjcheetham
pushed a commit
that referenced
this pull request
Mar 12, 2025
mjcheetham
pushed a commit
that referenced
this pull request
Mar 17, 2025
dscho
pushed a commit
that referenced
this pull request
Jun 6, 2025
dscho
pushed a commit
that referenced
this pull request
Jun 6, 2025
dscho
pushed a commit
that referenced
this pull request
Jun 11, 2025
dscho
pushed a commit
that referenced
this pull request
Jun 13, 2025
dscho
pushed a commit
that referenced
this pull request
Jun 16, 2025
dscho
pushed a commit
that referenced
this pull request
Jun 16, 2025
dscho
pushed a commit
that referenced
this pull request
Jun 16, 2025
dscho
pushed a commit
that referenced
this pull request
Jul 8, 2025
dscho
pushed a commit
that referenced
this pull request
Aug 5, 2025
dscho
pushed a commit
that referenced
this pull request
Aug 5, 2025
dscho
pushed a commit
that referenced
this pull request
Aug 8, 2025
dscho
pushed a commit
that referenced
this pull request
Aug 8, 2025
dscho
pushed a commit
that referenced
this pull request
Aug 13, 2025
dscho
pushed a commit
that referenced
this pull request
Aug 19, 2025
dscho
pushed a commit
that referenced
this pull request
Oct 17, 2025
dscho
pushed a commit
that referenced
this pull request
Oct 17, 2025
dscho
pushed a commit
that referenced
this pull request
Oct 17, 2025
dscho
pushed a commit
that referenced
this pull request
Oct 28, 2025
dscho
pushed a commit
that referenced
this pull request
Nov 5, 2025
dscho
pushed a commit
that referenced
this pull request
Nov 6, 2025
dscho
pushed a commit
that referenced
this pull request
Nov 6, 2025
dscho
pushed a commit
that referenced
this pull request
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If our POST request includes a commit ID, then the the remote will
send a pack-file containing the commit and all trees reachable from
its root tree. With the current implementation, this causes a
failure since we call install_loose() when asking for one object.
Modify the condition to check for install_pack() when the response
type changes.