Reset CTS in ReplicaSyncManager #1408
Open
+73
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #1407 by implementing a fix to reset the CancellationTokenSource (CTS) in the ReplicationSyncManager when synchronization operations fail. The changes ensure that failed replication sync operations can be retried with a fresh CTS instead of being permanently blocked.
Key changes:
- Modified CTS handling to allow resetting after failures
- Added proper disposal checks to prevent race conditions
- Introduced exception injection testing for the reset mechanism
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ReplicationSyncManager.cs | Core fix implementing CTS reset logic with disposal safety checks |
| ExceptionInjectionType.cs | Added new exception type for testing CTS reset functionality |
| ClusterReplicationDisklessSyncTests.cs | Added test case to verify CTS reset behavior works correctly |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
libs/cluster/Server/Replication/PrimaryOps/DisklessReplication/ReplicationSyncManager.cs
Show resolved
Hide resolved
libs/cluster/Server/Replication/PrimaryOps/DisklessReplication/ReplicationSyncManager.cs
Show resolved
Hide resolved
libs/cluster/Server/Replication/PrimaryOps/DisklessReplication/ReplicationSyncManager.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1407.