Skip to content

feature: support azure MangedIdentity TokenCredential #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

feature: support azure MangedIdentity TokenCredential #590

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2761e27
feature: support azure MangedIdentity TokenCredential
Meir017 Aug 14, 2024
3426b2d
feature: support azure MangedIdentity TokenCredential
Meir017 Aug 14, 2024
4c06110
feature: support azure MangedIdentity TokenCredential
Meir017 Aug 14, 2024
38aa6d4
Merge branch 'main' into feature/support-azure-token-credential
Meir017 Aug 15, 2024
873ec04
Merge branch 'main' into feature/support-azure-token-credential
Meir017 Aug 16, 2024
c32caa0
Merge branch 'main' into feature/support-azure-token-credential
badrishc Aug 18, 2024
48b2aec
Merge remote-tracking branch 'origin/main' into feature/support-azure…
Meir017 Oct 18, 2024
982b75e
allow testing locally
Meir017 Oct 20, 2024
7fcd8dc
Merge branch 'main' into feature/support-azure-token-credential
Meir017 Oct 20, 2024
c513e6e
format
Meir017 Oct 20, 2024
63694f0
fix tests
Meir017 Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feature: support azure MangedIdentity TokenCredential
  • Loading branch information
@Meir017
Meir017 committed Aug 14, 2024
commit 4c06110e99a913e5c21e1f8ab5490649a694b788
2 changes: 1 addition & 1 deletion libs/host/Configuration/Options.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ public GarnetServerOptions GetServerOptions(ILogger logger = null)
{
throw new InvalidAzureConfiguration("Cannot enable use-azure-storage without supplying storage-string or storage-service-uri & storage-managed-identity");
}
if (useAzureStorage && !string.IsNullOrEmpty(AzureStorageConnectionString)
if (useAzureStorage && !string.IsNullOrEmpty(AzureStorageConnectionString)
&& (!string.IsNullOrEmpty(AzureStorageServiceUri) || !string.IsNullOrEmpty(AzureStorageManagedIdentity)))
{
throw new InvalidAzureConfiguration("Cannot enable use-azure-storage with both storage-string and storage-service-uri or storage-managed-identity");
Expand Down