Terminal suggest addon should always multiply #270827
Open
+8
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the terminal suggest addon's line height calculation to match terminal-specific behavior, where line height values should always be multiplied by font size rather than following editor suggestion behavior. The change ensures consistent treatment with terminal configuration expectations.
Key changes:
- Removes dependency on
MINIMUM_LINE_HEIGHTconstant and always multiplies line height by font size - Replaces minimum line height enforcement with terminal-specific calculation using
GOLDEN_LINE_HEIGHT_RATIO
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestAddon.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the configuration description the treatment here should differ from regular editor suggest line heights:
Compare with:
Fixes #255851