fix: debugger is unresponsive to repl evaluation after switching #270461
+27
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the debug console becomes unresponsive when switching between debug sessions. The issue occurred when the debug console picker selected a parent session (wrapper) that couldn't handle REPL evaluations, instead of selecting a child session that could actually process evaluation requests.
- Introduces a centralized
resolveChildSessionutility function in debugUtils.ts - Refactors existing logic in repl.ts and debugCommands.ts to use the new utility
- Improves session selection to prefer child sessions over parent wrapper sessions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/debug/common/debugUtils.ts |
Adds new resolveChildSession utility function with proper logic to select the best child session |
src/vs/workbench/contrib/debug/browser/repl.ts |
Replaces inline session resolution logic with call to the new utility function |
src/vs/workbench/contrib/debug/browser/debugCommands.ts |
Replaces inline session resolution logic with call to the new utility function |
roblourens
reviewed
Oct 9, 2025
| if (stoppedChildSession && session.state !== State.Stopped) { | ||
| session = stoppedChildSession; | ||
| } | ||
| session = resolveChildSession(session, debugService.getModel().getSessions()); |
There was a problem hiding this comment.
What's the difference between this command and the one in repl.ts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152407:
Problem Analysis
The issue occurred when using the debug console picker to switch between consoles. If the selected session was a parent session (wrapper) with child sessions, the console would become unresponsive because it focused the parent session instead of a child that can actually handle evaluation requests.
Root Cause
The existing logic in both repl.ts and debugCommands.ts only looked for stopped child sessions, but ignored running child sessions. When both parent and children were running (not paused), the system would focus the parent session, which couldn't handle REPL evaluations properly.
Solution