Do not reference tslib.es6.js from package.json exports #208

andrewbranch · 2023-06-02T16:18:11Z

Fixes regression from #201

andrewbranch · 2023-06-02T16:20:37Z

package.json

            "module": {
-              "types": "./tslib.d.ts",
-              "default": "./tslib.es6.js"
+              "types": "./tslib/modules/index.d.ts",


This is where it would be great if we could say "types": "./tslib.d.ts?type=module"

This is a little bit of a lie but I don’t think it matters, for now 🤔 The most correct thing would be to fully duplicate tslib.d.ts to tslib.d.mts.

weswigham · 2023-06-02T16:43:37Z

package.json

-                "types": "./tslib.d.ts",
-                "default": "./tslib.es6.js"
+                "types": "./modules/index.d.ts",
+                "default": "./tslib.es6.mjs"


Do we have a test for a runtime whose conditions actually load this?

vite and webpack-5 in the test directory should; possibly others

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [tslib](https://www.typescriptlang.org/) ([source](https://togithub.com/Microsoft/tslib)) | [`^2.4.1` -> `^2.5.3`](https://renovatebot.com/diffs/npm/tslib/2.5.0/2.5.3) | [![age](https://badges.renovateapi.com/packages/npm/tslib/2.5.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/tslib/2.5.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/tslib/2.5.3/compatibility-slim/2.5.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/tslib/2.5.3/confidence-slim/2.5.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Microsoft/tslib</summary> ### [`v2.5.3`](https://togithub.com/microsoft/tslib/releases/tag/v2.5.3): tslib 2.5.3 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.5.2...v2.5.3) #### What's Changed - Do not reference tslib.es6.js from package.json exports by [@andrewbranch](https://togithub.com/andrewbranch) in [https://github.com/microsoft/tslib/pull/208](https://togithub.com/microsoft/tslib/pull/208) **Full Changelog**: microsoft/tslib@2.5.2...v2.5.3 ### [`v2.5.2`](https://togithub.com/microsoft/tslib/releases/tag/2.5.2): tslib 2.5.2 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.5.1...2.5.2) This release [explicitly re-exports helpers](https://togithub.com/microsoft/tslib/pull/204) to work around TypeScript's incomplete symbol resolution for tslib. ### [`v2.5.1`](https://togithub.com/microsoft/tslib/releases/tag/2.5.1): tslib 2.5.1 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.5.0...2.5.1) This release of tslib provides fixes for two issues. First, [it reverses the order of `init` hooks provided by decorators](https://togithub.com/microsoft/tslib/pull/202) to correctly reflect proposed behavior. Second, it [corrects the `exports` field of tslib's `package.json` and provides accurate declaration files](https://togithub.com/microsoft/tslib/pull/202) so that it may be consumed under the `node16` and `bundler` settings for `moduleResolution.` </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/valora-inc/wallet).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tslib](https://www.typescriptlang.org/) ([source](https://github.com/Microsoft/tslib)) | dependencies | patch | [`2.5.2` -> `2.5.3`](https://renovatebot.com/diffs/npm/tslib/2.5.2/2.5.3) | --- ### Release Notes <details> <summary>Microsoft/tslib</summary> ### [`v2.5.3`](https://github.com/microsoft/tslib/releases/tag/v2.5.3): tslib 2.5.3 [Compare Source](microsoft/tslib@2.5.2...v2.5.3) #### What's Changed - Do not reference tslib.es6.js from package.json exports by [@andrewbranch](https://github.com/andrewbranch) in microsoft/tslib#208 **Full Changelog**: microsoft/tslib@2.5.2...v2.5.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1921 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tslib](https://www.typescriptlang.org/) ([source](https://togithub.com/Microsoft/tslib)) | dependencies | patch | [`2.5.2` -> `2.5.3`](https://renovatebot.com/diffs/npm/tslib/2.5.2/2.5.3) | --- ### Release Notes <details> <summary>Microsoft/tslib</summary> ### [`v2.5.3`](https://togithub.com/microsoft/tslib/releases/tag/v2.5.3): tslib 2.5.3 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.5.2...v2.5.3) #### What's Changed - Do not reference tslib.es6.js from package.json exports by [@andrewbranch](https://togithub.com/andrewbranch) in [https://github.com/microsoft/tslib/pull/208](https://togithub.com/microsoft/tslib/pull/208) **Full Changelog**: microsoft/tslib@2.5.2...v2.5.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box  Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>

<p>This PR was automatically created by Snyk using the credentials of a real user.</p><br /><h3>Snyk has created this PR to upgrade tslib from 2.5.0 to 2.5.3.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **3 versions** ahead of your current version. - The recommended version was released **a month ago**, on 2023-06-02. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>tslib</b></summary> <ul> <li> <b>2.5.3</b> - <a href="https://snyk.io/redirect/github/microsoft/tslib/releases/tag/v2.5.3">2023-06-02</a></br><h2>What's Changed</h2> <ul> <li>Do not reference tslib.es6.js from package.json exports by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/andrewbranch/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://snyk.io/redirect/github/andrewbranch">@ andrewbranch</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1738475228" data-permission-text="Title is private" data-url="microsoft/tslib#208" data-hovercard-type="pull_request" data-hovercard-url="/microsoft/tslib/pull/208/hovercard" href="https://snyk.io/redirect/github/microsoft/tslib/pull/208">#208</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://snyk.io/redirect/github/microsoft/tslib/compare/2.5.2...v2.5.3"><tt>2.5.2...v2.5.3</tt></a></p> </li> <li> <b>2.5.2</b> - <a href="https://snyk.io/redirect/github/microsoft/tslib/releases/tag/2.5.2">2023-05-18</a></br><p>This release <a href="

Do not reference tslib.es6.js from package.json exports

80deca0

andrewbranch commented Jun 2, 2023

View reviewed changes

RyanCavanaugh approved these changes Jun 2, 2023

View reviewed changes

andrewbranch merged commit a471c51 into main Jun 2, 2023

andrewbranch deleted the moar-modules branch June 2, 2023 16:30

weswigham reviewed Jun 2, 2023

View reviewed changes

slavanossar mentioned this pull request Jun 20, 2023

build with nuxt3 not find tslib nuxt-modules/apollo#516

Open

jcesarioatpeach mentioned this pull request Jun 26, 2023

[Snyk] Upgrade tslib from 2.0.0 to 2.5.3 peachfinance/redoc#5

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Do not reference tslib.es6.js from package.json exports #208

Do not reference tslib.es6.js from package.json exports #208

Uh oh!

andrewbranch commented Jun 2, 2023

Uh oh!

andrewbranch Jun 2, 2023

Uh oh!

weswigham Jun 2, 2023

Uh oh!

andrewbranch Jun 2, 2023

Uh oh!

Do not reference tslib.es6.js from package.json exports #208

Do not reference tslib.es6.js from package.json exports #208

Uh oh!

Conversation

andrewbranch commented Jun 2, 2023

Uh oh!

andrewbranch Jun 2, 2023

Choose a reason for hiding this comment

Uh oh!

weswigham Jun 2, 2023

Choose a reason for hiding this comment

Uh oh!

andrewbranch Jun 2, 2023

Choose a reason for hiding this comment

Uh oh!