Skip to content

Conversation

@andrewbranch
Copy link
Member

Fixes #274

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should add a cjs-module-lexer test just to verify that these work (I did it manually to check too).

@andrewbranch
Copy link
Member Author

@andrewbranch andrewbranch merged commit 11fa982 into main Oct 31, 2024
3 checks passed
@andrewbranch andrewbranch deleted the bug/es5-compat branch October 31, 2024 22:39
@jakebailey
Copy link
Member

Yeah, missed that 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version 2.8.0 ES5 Incompatibility

3 participants