Use cryptohash-sha1 instead of the deprecated cryptohash #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also drops several transitive dependencies like cryptonite, memory and basement
|
The CI failures look unrelated FTR, but maybe it is as easy as regenerating the Haskell-CI config, should I do that in this PR? |
|
Sure, regenerated CI config would be appreciated, thanks! Also thanks for the overall change, it particularly makes sense as the sha1 is only used by store at compile time, so that mitigates most concerns about differences in speed. |
|
Pushed, CI should work now:
|
|
Anything I could do to move this forward? |
|
Argh, sorry for the huge delay! Somehow got buried in my email. Thanks for all the fixes! |
Closed
mgsloan
added a commit
that referenced
this pull request
Oct 6, 2023
Hackage release of the prior versions was bungled so they didn't include the changes from #175
|
Fixes included in store-0.7.18, store-core-0.4.4.6, store-streaming-0.2.0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also drops several transitive dependencies like cryptonite, memory and basement
Closes #52