This PR needs PR #1307.

The problem of consistency was related to a missing call to Package.TypeCheck().

The UnexportedReturnRule calls Package.TypeOf(), but this requires the data from Package.TypeCheck(): depending on the order of the rule, the data may exist or may not.

I checked the calls to Package.TypeOf(), and it is only missing for unexported-return.

The bad news is that unexported-return is now a part of the other issue about Package.TypeCheck().
Concretely, it was already a part of this issue as it relies on Package.TypeOf().

The regression comes from #1170 (v1.6.0); this explains why the number of issues has increased since the beginning of the year.

Note: I also fixed a problem with a missing call to types.Unalias().

Fixes #1306

Note: numbers have changed (723 -> 722) because I replaced wc with jq (so no extra empty line).

$ ./revive-bench.sh
722
722
722
722
...
722
722
722

#!/bin/bash -e

for a in {1..1000}; do
    revive -formatter json ./... | jq '. |length'
done