Skip to content

Removing dependency algo.generic #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

Removing dependency algo.generic #39

merged 2 commits into from
Jun 10, 2025

Conversation

@tsplude
Copy link
Contributor

@tsplude tsplude commented Jun 10, 2025

We lean on algo.generic for a single call to approx= and it causes a number of warnings downstream

Running MB backend before:

(p) tplude ~ MB_EDITION=ee clj -M:dev:drivers:ee:ee-dev:cider/nrepl
2025-06-10 18:58:42,832 INFO metabase.util :: Maximum memory available to JVM: 9.0 GB
Reflection warning, clojure/algo/generic/math_functions.clj:103:3 - call to static method abs on java.lang.Math can't be resolved (argument types: unknown).
Reflection warning, clojure/algo/generic/math_functions.clj:107:4 - reference to field abs can't be resolved.
Reflection warning, clojure/algo/generic/math_functions.clj:109:4 - call to method abs can't be resolved (target class is unknown).
Reflection warning, clojure/algo/generic/math_functions.clj:113:3 - reference to field abs can't be resolved.
Reflection warning, clojure/algo/generic/math_functions.clj:117:13 - reference to field bipart can't be resolved.
Reflection warning, clojure/algo/generic/math_functions.clj:118:40 - reference to field lpart can't be resolved.
Reflection warning, clojure/algo/generic/math_functions.clj:119:46 - reference to field bipart can't be resolved.
Reflection warning, clojure/algo/generic/math_functions.clj:148:26 - call to static method round on java.lang.Math can't be resolved (argument types: unknown).
Reflection warning, clojure/algo/generic/math_functions.clj:148:26 - call to static method round on java.lang.Math can't be resolved (argument types: unknown).
Reflection warning, clojure/algo/generic/math_functions.clj:160:3 - call to method round can't be resolved (target class is unknown).
nREPL server started on port 54321 on host localhost - nrepl://localhost:54321

Running MB backend after (and removing this):

(p) tplude ~ MB_EDITION=ee clj -M:dev:drivers:ee:ee-dev:cider/nrepl
2025-06-10 20:38:55,452 INFO metabase.util :: Maximum memory available to JVM: 9.0 GB
nREPL server started on port 54321 on host localhost - nrepl://localhost:54321

@tsplude tsplude requested a review from camsaul as a code owner June 10, 2025 20:46
@tsplude tsplude merged commit 1fe839c into main Jun 10, 2025
2 checks passed
@tsplude tsplude deleted the remove-dep-algo-generic branch June 10, 2025 21:04
@tsplude tsplude mentioned this pull request Jun 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpsutton dpsutton dpsutton approved these changes

@camsaul camsaul Awaiting requested review from camsaul camsaul is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tsplude @dpsutton