This repository was archived by the owner on Jul 27, 2025. It is now read-only.
Fix conversion for European format #1908
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it be easier and less error prone to take the string and make it in to characters, then split on the separator and ignore the delimiter. Something like this amount = "-233.002,23"
separator = ","
delimiter = "."
whole, cents = amount.chars.split(separator)
whole.reject! { it == delimiter }
p Float("#{whole.join}.#{cents.join}") |
|
@henrikbjorn might be. I just follow existing convention |
|
Maybe you can try def sanitize_number(value, delimiter: ',', separator: '.')
return "" if value.nil?
mains, cents = value.to_s.split(separator)
mains.gsub!(/[^0-9\#{Regex.escape(delimiter)}\-]/, '')
"#{mains}.#{cents}"
end
p sanitize_number("123,456.78")
p sanitize_number("-123,456.78")
p sanitize_number("12 456.78")
p sanitize_number("12 456,78", separator: ',', delimiter: '.') |
zachgoll
suggested changes
Feb 26, 2025
There was a problem hiding this comment.
Thanks for the fix!
I think I agree with @henrikbjorn on this one that this is more of a parsing issue than anything.
To merge this, I think we need to:
- Remove the extra format
- Update parsing to handle both
1.234,56and1234,56properly - Remove the tests here and update the "Parses European number format correctly" test to have an additional CSV row (for total of 2 rows) with each of these formats.
|
Fix was actually a bit simpler than I had thought—the parsing logic is fine, but the form was not properly applying the configuration. Superseded by #1923 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow for this
https://discord.com/channels/1191501936281784361/1342779772970729533/1342779772970729533