Skip to content
This repository was archived by the owner on Jul 27, 2025. It is now read-only.

Account namespace updates: part 1 (accountable types) #893

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Account namespace updates: part 1 (accountable types) #893

merged 5 commits into from
Jun 20, 2024

Conversation

zachgoll
Copy link
Collaborator

@zachgoll zachgoll commented Jun 19, 2024 •
edited
Loading

See #892 for a detailed proposal of these changes. I will be opening several PRs to achieve the final state so there is a semi-readable history of the changes.

Part 1 is intended to:

  1. Add system tests for creating various types of accounts
  2. Move accountable "subtypes" to the global namespace

Before this PR:

app/models
├── account
│   ├── balance
│   │   └── calculator.rb
│   ├── balance.rb
│   ├── credit.rb
│   ├── crypto.rb
│   ├── depository.rb
│   ├── investment.rb
│   ├── loan.rb
│   ├── other_asset.rb
│   ├── other_liability.rb
│   ├── property.rb
│   ├── syncable.rb
│   └── vehicle.rb
├── account.rb

After this PR:

app/models
├── account
│   ├── balance
│   │   └── calculator.rb
│   ├── balance.rb
│   └── syncable.rb
├── account.rb
├── credit_card.rb
├── crypto.rb
├── depository.rb
├── investment.rb
├── loan.rb
├── other_asset.rb
├── other_liability.rb
├── property.rb
└── vehicle.rb

zachgoll added 5 commits June 19, 2024 11:26
@zachgoll
Rename accountable types
962360b
@zachgoll
Merge branch 'main' of github.com:maybe-finance/maybe into zachgoll/m…
8a5dce3 
…odel-routing-reorganization-and-cleanup

# Conflicts:
#	db/schema.rb
#	test/fixtures/account/investments.yml
#	test/fixtures/account/loans.yml
#	test/fixtures/account/other_liabilities.yml
#	test/fixtures/account/properties.yml
#	test/fixtures/account/vehicles.yml
#	test/fixtures/accounts.yml
#	test/models/account_test.rb
@zachgoll
Merge conflicts
9b8511b
@zachgoll
Fix broken tests
987fc3c
@zachgoll
Add back sidebar changes
0e275f0
@zachgoll zachgoll marked this pull request as draft June 20, 2024 10:57
@zachgoll zachgoll marked this pull request as ready for review June 20, 2024 11:03
@zachgoll zachgoll changed the title Account namespace updates Account namespace updates: part 1 Jun 20, 2024
@zachgoll zachgoll merged commit a947db9 into main Jun 20, 2024
@zachgoll zachgoll deleted the zachgoll/model-routing-reorganization-and-cleanup branch June 20, 2024 11:26
@zachgoll zachgoll changed the title Account namespace updates: part 1 Account namespace updates: part 1 (accountable types) Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zachgoll