This repository was archived by the owner on Jul 27, 2025. It is now read-only.
Add Notifications UI #455
Closed
Add Notifications UI #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay. |
9a612c5 to
09d8c16
Compare
Resolves #447
/claim #447
Some key things to note:
- Adds notifications UI
- This implementation supports both flash on redirects (ex: `redirect_to(root_path, alert: "Something went wrong")` as well as flash on turbo stream responses (ex: `turbo_stream.flash(alert: "Something went wrong")`)
- Replaces flash helper in auth views
09d8c16 to
f13482b
Compare
jclusso
commented
Feb 13, 2024
Comment on lines
+207
to
+211
| keyframes: { | ||
| 'stroke-fill': { | ||
| to: { 'stroke-dashoffset': 0 }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Credit to @JoshAntBrown since I stole this from #449. I'm not crazy about having to add something to the tailwind config, so if there is a better way to do this, let me know.
|
Awesome, thorough code! 👏🏻 |
henrikbjorn
reviewed
Feb 13, 2024
| def flash_message(flash) | ||
| messages = flash.map do |type, message| | ||
| turbo_stream_action_tag(:flash_message, type: type, message: message) | ||
| end.join.html_safe |
There was a problem hiding this comment.
You can also use .safe_join https://api.rubyonrails.org/classes/ActionView/Helpers/OutputSafetyHelper.html#method-i-safe_join
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #447
/claim #447
Some key things to note:
redirect_to(root_path, alert: "Something went wrong")as well as flash on turbo stream responses (ex:turbo_stream.flash(alert: "Something went wrong"))maybe_notification_ui-compressed.mov