Add native encryption support to Mjolnir #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
950a5e4 to
c8b3634
Compare
turt2live
approved these changes
Oct 1, 2024
Comment on lines
+25
to
+26
| # Note that this option is now deprecated as native encryption is now supported in mjolnir, | ||
| # and will be removed at a later date. |
There was a problem hiding this comment.
we should call this out in the release notes when we get there
This was referenced Oct 1, 2024
Gnuxie
reviewed
Oct 3, 2024
Comment on lines
-139
to
-143
| if (e.isAxiosError && e?.response?.data?.errcode === 'M_USER_IN_USE') { | ||
| // Then we've already registered the user in a previous run and that is ok. | ||
| } else { | ||
| throw e; | ||
| } |
There was a problem hiding this comment.
For some historical context
This code is redundant and the version that "actually works" is here. It's not flagged up by typescript as dead code because the error will be implicitly typed as any rather than unknown.
e.isAxiosError is there because at one point axios was used, and then removed in order to just reuse the http client the matrix-bot-sdk brings (accessed via getRequestFn).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.