Ensure the create event is cached prior to sorting #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
+ Coverage 53.44% 53.45% +0.01%
==========================================
Files 52 52
Lines 7825 7838 +13
==========================================
+ Hits 4182 4190 +8
- Misses 3239 3243 +4
- Partials 404 405 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
They would previously include the create event because `stateNeeded` returns the state needed for auth purposes, not for setting `auth_events`.
This reverts commit 908a63a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Else calling
ReverseTopologicalOrderingwill fail on v12 rooms.