This repository was archived by the owner on Sep 1, 2025. It is now read-only.
Internal recommendations #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here we go: |
|
Thanks @mcl22 ! |
Has been implemented directly in Kodi-Voice.
Was modified to support a change in Kodi-Voice that I ultimately reverted.
8f7ae39 to
c6c5308
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove script.skin.helper.widgets dependency and provide a similar implementation.
The biggest difference is that this doesn't filter on rating, but instead sorts on it, limits the number of items, and picks a random item from that. The benefit of doing it this way is that we always have something to recommend.
It is also much faster since we're not pinging an addon for the info.
Additionally, this adds support for filtering recommendations on a supplied Genre.
Requires changes to Kodi-Voice provided by m0ngr31/kodi-voice#19
Addresses Issue #193.