Skip to content
This repository was archived by the owner on Sep 1, 2025. It is now read-only.

Conversation

jingai
Copy link
Collaborator

@jingai jingai commented Aug 8, 2017

This PR tries to extend genre support everywhere applicable. Previously, we supported specifying a genre only in WatchRandomMovie. This extends it to the existing View Intents and creates the following new Intents:

ViewMusicVideos
WatchRandomShow
WatchRandomMusicVideo

Two new slots were required for this:

SHOWGENRES
MUSICVIDEOGENRES

These have been added to web slot generator already and the Python generator is updated in this PR.

Additionally, this requires already-released changes to Kodi-Voice in 0.9.6.

jingai added 7 commits August 3, 2017 23:06
If an unwatched show is found, play the next unwatched episode of that
show rather than a random one.

If no unwatched shows are found, play a random episode of a random show.
@mcl22
Copy link

mcl22 commented Aug 9, 2017

Here are the translations:

playing_genre_musicvideo: "Spiele das {{ genre_name }} Musikvideo {{ musicvideo_name }} von {{ artist_name }}"
playing_musicvideo: "Spiele das Musikvideo {{ musicvideo_name }} von {{ artist_name }}"
playing_random_show: "Spiele eine zufällige Serie"
playing_random_show_genre: "Spiele eine zufällige {{ genre }} Serie"
playing_random_musicvideo: "Spiele ein zufälliges Musikvideo"
playing_random_musicvideo_genre: "Spiele ein zufälliges {{ genre }} Musikvideo"

WatchRandomShow zeige eine (/zufällige) (/{ShowGenre}) Serie
WatchRandomMusicVideo zeige ein (/zufälliges) (/{MusicVideoGenre}) Musikvideo

ViewMovies (suche/finde) {MovieGenre} Filme
ViewMovies suche nach {MovieGenre} Filmen
ViewShows (suche/suche nach/finde) {ShowGenre} Serien
ViewMusic (suche/suche nach/finde) {MusicGenre} Musik
ViewMusicVideos (suche/suche nach/finde) {MusicVideoGenre} Musikvideos

@jingai
Copy link
Collaborator Author

jingai commented Aug 9, 2017

Thanks @mcl22. Could you verify that all of these are now correct? Thanks!

ViewMovies (öffne/gehe zu) Filme
ViewMovies (suche/finde) {MovieGenre} Filme
ViewMovies suche nach {MovieGenre} Filmen
ViewShows (öffne/gehe zu) Serien
ViewShows (suche/suche nach/finde) {ShowGenre} Serien
ViewMusic (öffne/gehe zu) Musik
ViewMusic (suche/suche nach/finde) {MusicGenre} Musik
ViewArtists (öffne/gehe zu) (Künstler/Musiker/Interpreten)
ViewAlbums (öffne/gehe zu) Alben
ViewMusicVideos (öffne/gehe zu) Musikvideos
ViewMusicVideos (suche/suche nach/finde) {MusicVideoGenre} Musikvideos
ViewAudioPlaylist (öffne/gehe zu) (Musik/Lieder/Song) playlist {AudioPlaylist}
ViewAudioPlaylist (öffne/gehe zu) {AudioPlaylist} (Musik/Lieder/Song) playlist
ViewAudioPlaylistRecent (öffne/gehe zu) neue (Musik/Lieder/Songs)
ViewAudioPlaylistRecent (öffne/gehe zu) (zuletzt/kürzlich) hinzugefügte (Musik/Lieder/Songs)
ViewVideoPlaylist (öffne/gehe zu) (Film/Serie/Video) playlist {VideoPlaylist}
ViewVideoPlaylist (öffne/gehe zu) {VideoPlaylist} (Film/Serie/Video) playlist
ViewMoviePlaylistRecent (öffne/gehe zu) neue (Films/Videos)
ViewMoviePlaylistRecent (öffne/gehe zu) (zuletzt/kürzlich) hinzugefügte (Films/Videos)
ViewEpisodePlaylistRecent (öffne/gehe zu) neue Series
ViewEpisodePlaylistRecent (öffne/gehe zu) (zuletzt/kürzlich) hinzugefügte Series
ViewEpisodePlaylistRecent (öffne/gehe zu) neue Musikvideos
ViewEpisodePlaylistRecent (öffne/gehe zu) (zuletzt/kürzlich) hinzugefügte Musikvideos
ViewPlaylist (öffne/gehe zu) playlist {AudioPlaylist}
ViewPlaylist (öffne/gehe zu) {AudioPlaylist} playlist
ViewPlaylist (öffne/gehe zu) playlist {VideoPlaylist}
ViewPlaylist (öffne/gehe zu) {VideoPlaylist} playlist

@mcl22
Copy link

mcl22 commented Aug 9, 2017

Wow, this one is pretty difficult :)
First, here are my changes:
ViewVideoPlaylist (öffne/gehe zu) (Film/Serie/Video) playlist {VideoPlaylist}
ViewVideoPlaylist (öffne/gehe zu) (Filme/Serien) playlist {VideoPlaylist}
ViewMoviePlaylistRecent (öffne/gehe zu) neue (Filme/Videos)
ViewMoviePlaylistRecent (öffne/gehe zu) (zuletzt/kürzlich) hinzugefügte (Filme/Videos)
ViewEpisodePlaylistRecent (öffne/gehe zu) neue Serien
ViewEpisodePlaylistRecent (öffne/gehe zu) (zuletzt/kürzlich) hinzugefügten Serien

There are some more one could change but it's not so easy. For instance,
ViewAudioPlaylistRecent (öffne/gehe zu) (zuletzt/kürzlich) hinzugefügte (Musik/Lieder/Songs)
One could say "gehe zu kürzlich hinzugefügteR Musik" but you could also say "... hinzugefügte Musik" if you treat "kürzlich hinzugefügte Musik" as an "item", something static, for example a menu entry. Then you go to this entry and refer to that. But if you'd like to refer to the recently added music it would be "kürzlich hinzugefügter Musik".
With those corrections above I tried to match it to something I would use, don't know about others :) I could translate every possible version (as Amazon suggests) but then once again we would blow up the utterances :)
So, let's try it this way.

@jingai
Copy link
Collaborator Author

jingai commented Aug 9, 2017

ViewVideoPlaylist (öffne/gehe zu) (Film/Serie/Video) playlist {VideoPlaylist}
ViewVideoPlaylist (öffne/gehe zu) (Filme/Serien) playlist {VideoPlaylist}

Are you trying to say that this isn't corect as an alternate:

(öffne/gehe zu) {VideoPlaylist} (Film/Filme/Serie/Serien/Video) playlist

?

Note the orientation of the word playlist

@jingai
Copy link
Collaborator Author

jingai commented Aug 9, 2017

Going to merge this as it is for now. There's a few other instances of these words that might need adjustments too, so let's treat that as its own Issue.

I think Alexa might catch things like film vs filme and serie vs serien on her own anyway. Let me know if that's the case.

@jingai jingai merged commit 93afcfb into m0ngr31:master Aug 9, 2017
@jingai jingai deleted the extend-genre-support branch August 9, 2017 23:11
@mcl22
Copy link

mcl22 commented Aug 10, 2017

Concerning (öffne/gehe zu) {VideoPlaylist} (Film/Filme/Serie/Serien/Video) playlist, that was my fault :) Of course this works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants