Skip to content
This repository was archived by the owner on Sep 1, 2025. It is now read-only.

Conversation

digiltd
Copy link
Contributor

@digiltd digiltd commented Jul 29, 2017

opens the found video playlist in the GUI

requires the updated kodi-voice: m0ngr31/kodi-voice#17

I cobbled together a DE translation based on the exisiting ViewMoviews, ViewShows

ViewVideoPlaylist (öffne/gehe zu) video playlist {VideoPlaylist}
ViewVideoPlaylist (öffne/gehe zu) {VideoPlaylist} video playlist

Though need a translation for the template

showing_empty: "Showing"

@jingai
Copy link
Collaborator

jingai commented Jul 31, 2017

I think this should be self-contained rather than recycling alexa_watch_video_playlist(), like the others are. Since it's a nav command, there shouldn't be a response either (it should return question(' ')).

Why did the German utterance file change so much? I ran the them through the utterance generator to check, and nothing else changed like it did in this PR.

Lastly, we'll need to add at the same time support for audio playlists and a 'generic' phrasing that excludes the playlist type to line up with the other commands (i.e., open playlist foo). This needs to happen simultaneously to ensure there aren't collisions with each other or the other Intents that are similar.

We'll need to test for weighting issues as well with shorter open commands (open movies vs open movie playlist, etc), since it's possible Alexa might favor these new commands much more due to the slots involved, which equates to more sample phrases.

@jingai
Copy link
Collaborator

jingai commented Jul 31, 2017

If we add much more for open here, we might also want to consider removing open as an invocation word for AddonExecute.

@jingai
Copy link
Collaborator

jingai commented Jul 31, 2017

Superseded by #207 which includes what I talked about above.

@jingai jingai closed this Jul 31, 2017
@digiltd digiltd deleted the view-video-playlist branch August 27, 2017 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants