Skip to content
This repository was archived by the owner on Sep 1, 2025. It is now read-only.

Add support for music genres. #199

Closed
wants to merge 2 commits into from
Closed

Add support for music genres. #199

wants to merge 2 commits into from

Conversation

jingai
Copy link
Collaborator

@jingai jingai commented Jul 7, 2017 •
edited
Loading

Adds support for requesting music by genre. With this, you can say things like:

play Rock music
listen to Classical genre
shuffle Rap songs
listen to Christmas music by Scott Weiland

I've tested it some, but it is definitely possible the utterances might clash, so I wanted to get this up here as a PR for others to play with.

Obviously, the web slot generator needs to be updated to output MUSICGENRES as well.

Addresses Issue #107.

@jingai jingai requested a review from m0ngr31 July 7, 2017 22:07
@jingai jingai mentioned this pull request Jul 7, 2017
Closed
@jingai jingai force-pushed the music-genres branch 2 times, most recently from 923a980 to e0b7754 Compare July 9, 2017 08:18
@jingai
Copy link
Collaborator Author

jingai commented Jul 9, 2017

@mcl22 and @ausweider please check over the German translations and make sure they're working for you.

@jingai jingai force-pushed the music-genres branch 2 times, most recently from 5b128c0 to ab6f0c8 Compare July 11, 2017 16:49
@danielmasur
Copy link
Contributor

Looks good to me.
Side note: the german utterances are in dire need of a rewrite in the future though.

@jingai jingai closed this Jul 25, 2017
@jingai jingai deleted the music-genres branch July 25, 2017 03:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@m0ngr31 m0ngr31 Awaiting requested review from m0ngr31

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jingai @danielmasur