Skip to content
This repository was archived by the owner on Sep 1, 2025. It is now read-only.

Conversation

jingai
Copy link
Collaborator

@jingai jingai commented Aug 10, 2016

Currently only supports music playlists.

This does require similar changes in your slot generator, as I changed the name of the MUSIC slot to MUSICARTISTS and added MUSICPLAYLISTS slot as well.

I'll submit another pull request for the changes to the slot generator.

Currently only supports music playlists.
@jingai
Copy link
Collaborator Author

jingai commented Sep 15, 2016

If you don't intend to pull any of these, please just let me know so I can merge them all into master on my fork and continue on.

@40wattrange
Copy link

If you do please let me know. I've liked your modifications and have ideas
for more. Would just switch my repo.

On Sep 14, 2016 8:52 PM, "jingai" [email protected] wrote:

If you don't intend to pull any of these, please just let me know so I can
merge them all into master on my fork and continue on.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#10 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABI0DpfEt8-JiO4tztievrdZmmij-o9Oks5qqKT4gaJpZM4JhcKb
.

@m0ngr31
Copy link
Owner

m0ngr31 commented Sep 15, 2016

I do plan on merging this in. Thank you for the PR. I have just been swamped between work and a client project. I really just need to spend some time and update the documentation and I'll me ready to merge my changes in as well.

@jingai
Copy link
Collaborator Author

jingai commented Sep 15, 2016

No problem. Was just making sure you were still there :)

@m0ngr31
Copy link
Owner

m0ngr31 commented Sep 15, 2016

I'm hoping in the next week I'll be able to get all of your PRs merged + update docs + merge my local dev branch

@m0ngr31 m0ngr31 merged commit bb9e590 into m0ngr31:master Sep 28, 2016
@m0ngr31
Copy link
Owner

m0ngr31 commented Sep 28, 2016

I merged this in, I'll need to update the docs now.

@jingai
Copy link
Collaborator Author

jingai commented Sep 29, 2016

One comment: on "ListenToPlaylist listen to playlist {Playlist}" and all related, I added "ListenToPlaylist listen to {Playlist} playlist" as a variant because it seems my wife and I naturally speak the phrase differently. I figured this might be an issue for others too.

I can make another PR for the variants, unless you're opposed to the idea.

edit: Added to #12

@jingai jingai deleted the listentoplaylist branch September 29, 2016 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants