Align to new drivers hook option #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align the source code to compile using default setting for new target_drivers_hook. This makes more sense as the hook should be independent of any specific driver order.
|
@sijnstra Looks good! You may want to force the |
|
@Zeal8bit Interestingly the reason I added this was because the default was to use it. I can try to add it explicitly as well, but it seemed to be the general default when I tried to build 0.6.0. |
|
@Zeal8bit added - I did a quick look and yes it seems that the variable is inherited from the first use. Makes sense to make it explicit in case of future change. |
|
Looks good, thanks! (and sorry for the delay!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align the source code to compile using default setting for new target_drivers_hook. This makes more sense as the hook should be independent of any specific driver order.