Skip to content

support all of fallback methods on ConsoleContext #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2018
Merged

support all of fallback methods on ConsoleContext #184

merged 1 commit into from
Feb 5, 2018

Conversation

@chentsulin
Copy link
Collaborator

@chentsulin chentsulin commented Feb 5, 2018 •
edited
Loading

With fallbackMethods: true, we can test all of methods using ConsoleBot:

const bot = new ConsoleBot({ fallbackMethods: true });

bot.onEvent(async context => {
  await context.sendText('Hello World');
  await context.sendImage('https://example.com/vr.jpg');
  await context.sendButtonTemplate('What do you want to do next?', [
    {
      type: 'web_url',
      url: 'https://petersapparel.parseapp.com',
      title: 'Show Website',
    },
    {
      type: 'postback',
      title: 'Start Chatting',
      payload: 'USER_DEFINED_PAYLOAD',
    },
  ]);
});

Result:

Bot > Hello World
Bot > sendImage: ["https://example.com/vr.jpg"]
Bot > sendButtonTemplate: ["What do you want to do next?",[{"type":"web_url","url":"https://petersapparel.parseapp.com","title":"Show Website"},{"type":"postback","title":"Start Chatting","payload":"USER_DEFINED_PAYLOAD"}]]

@chentsulin chentsulin force-pushed the console-fallback-methods branch from f2627bb to d72e8e9 Compare February 5, 2018 04:39
tw0517tw
tw0517tw reviewed Feb 5, 2018
View reviewed changes
src/context/ConsoleContext.js Outdated
// should return undefined when check if it is a promise
if (key === 'then') return;
return async (...args) => {
await target._methodMissing.call(target, key, args);
Copy link
Collaborator

@tw0517tw tw0517tw Feb 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just await target._methodMissing(key, args);?

@chentsulin chentsulin force-pushed the console-fallback-methods branch from d72e8e9 to 6e0952b Compare February 5, 2018 09:56
@chentsulin chentsulin merged commit 88d0e6c into master Feb 5, 2018
@chentsulin chentsulin deleted the console-fallback-methods branch February 5, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tw0517tw tw0517tw tw0517tw left review comments

+1 more reviewer

@homerchen19 homerchen19 homerchen19 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chentsulin @tw0517tw @homerchen19