Skip to content

fix(create-bottender-app): fix context concat and env name #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2020
Merged

fix(create-bottender-app): fix context concat and env name #859

merged 1 commit into from
Aug 25, 2020

Conversation

@chentsulin
Copy link
Collaborator

  • replace SLACK_VERIFICATION_TOKEN to SLACK_SIGNING_SECRET

@chentsulin chentsulin requested a review from etrex August 25, 2020 07:50
@codecov-commenter
Copy link

Codecov Report

Merging #859 into master will decrease coverage by 0.04%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
- Coverage   83.27%   83.23%   -0.05%     
==========================================
  Files         108      108              
  Lines        5644     5647       +3     
  Branches     1365     1422      +57     
==========================================
  Hits         4700     4700              
+ Misses        921      919       -2     
- Partials       23       28       +5
Impacted Files Coverage Δ
packages/bottender/src/server/Server.ts 8.69% <0.00%> (-0.30%) ⬇️
packages/bottender/src/slack/SlackEvent.ts 93.84% <ø> (ø)
packages/bottender/src/slack/routes.ts 100.00% <ø> (ø)
...create-bottender-app/src/utils/generateAppEntry.ts 0.00% <ø> (ø)
packages/bottender-dialogflow/src/index.ts 95.45% <100.00%> (ø)
...ackages/bottender/src/session/MongoSessionStore.ts 97.82% <100.00%> (ø)
packages/bottender/src/getClient.ts 52.63% <0.00%> (ø)
packages/create-bottender-app/src/shared/log.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb639da...2f81862. Read the comment docs.

@chentsulin chentsulin merged commit 05953ff into master Aug 25, 2020
@chentsulin chentsulin deleted the fix-ts-template branch August 25, 2020 08:01
chentsulin added a commit that referenced this pull request Sep 9, 2020
@chentsulin
fix(create-bottender-app): fix context concat and env name (#859)
acbc936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etrex etrex etrex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chentsulin @codecov-commenter @etrex