get/set/delete user level persistent menu for context user #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2020 11:44
98f37b1 to
2b4b7da
Compare
|
@hch903 Please rebase or master release/1.5 to get the latest MessengerClient. |
… bottender instead (Yoctol#810)
Codecov Report
@@ Coverage Diff @@
## release/1.5 #790 +/- ##
===============================================
+ Coverage 81.08% 83.94% +2.85%
===============================================
Files 108 120 +12
Lines 4747 6190 +1443
Branches 1197 1534 +337
===============================================
+ Hits 3849 5196 +1347
- Misses 862 990 +128
+ Partials 36 4 -32
Continue to review full report at Codecov.
|
chentsulin
requested changes
Jun 22, 2020
| false, | ||
| `getPersistentMenu: should not be called in context without session` | ||
| ); | ||
| return; |
| ); | ||
| } | ||
|
|
||
| async getPersistentMenu( |
There was a problem hiding this comment.
Sorry my bad. Now I'd name it to getUserPersistentMenu.
| ); | ||
| } | ||
|
|
||
| async setPersistentMenu( |
| ); | ||
| } | ||
|
|
||
| async deletePersistentMenu( |
There was a problem hiding this comment.
deleteUserPersistentMenu
chentsulin
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get/set/delete user level persistent menu for context user