ci: cache poetry #456
Merged
ci: cache poetry #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinr1234
approved these changes
Oct 18, 2022
JST5000
reviewed
Oct 24, 2022
| - name: Install poetry | ||
| run: pipx install poetry | ||
| run: | | ||
| curl -sSL https://install.python-poetry.org/ | python - |
Contributor
There was a problem hiding this comment.
Is -sSL supposed to be camelCase?
Collaborator
Author
There was a problem hiding this comment.
s, S, and L are all independent flags.
More details are here: https://curl.se/docs/manpage.html
JST5000
approved these changes
Oct 24, 2022
justinr1234
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR caches the installation of
poetry. It shaves about 10-15 seconds off of CI. It also fixes an issue where we were unintentionally installing Python twice.Context of Change
Everybody likes speedy CI.
I implemented this in XRPLF/xbridge-cli#62 and figured I might as well do it here too.
Type of Change
Test Plan
Works in CI.