Move Smart Escrow tests to separate file #5849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ripple/smart-escrow #5849 +/- ##
===================================================
Coverage 79.5% 79.5%
===================================================
Files 825 825
Lines 74475 74475
Branches 8463 8453 -10
===================================================
+ Hits 59172 59190 +18
+ Misses 15303 15285 -18 see 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
oleks-rip
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR moves the Smart Escrow-specific tests to a separate file (
EscrowSmart_test.cpp), to make it easier to test.This also enables us to easily run all the general escrow tests on different amendment combinations, so we can now test them on
all - featureSmartEscrowandall - featureTokenEscrow - featureSmartEscrow.Context of Change
Cleanup
Type of Change
API Impact
N/A
Test Plan
CI still passes.