change log to debug level for AMM offer retrieval and IOU payment check #5686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reduces log noise by downgrading two log statements from error/warn to debug level. These logs occur during normal pathfinding operations when expected scenarios happen that don't warrant elevated logging.
- Change DirectStep IOU authorization check log from warn to debug level
- Change AMMLiquidity offer retrieval log from error to debug level and improve message clarity
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/xrpld/app/paths/detail/DirectStep.cpp | Downgrades IOU authorization failure log from warn to debug level |
| src/xrpld/app/paths/detail/AMMLiquidity.cpp | Downgrades AMM offer retrieval log from error to debug and improves message clarity |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Bronek
approved these changes
Aug 14, 2025
bthomee
approved these changes
Aug 14, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5686 +/- ##
=========================================
- Coverage 78.8% 78.8% -0.0%
=========================================
Files 814 814
Lines 71304 71303 -1
Branches 8348 8369 +21
=========================================
- Hits 56187 56160 -27
- Misses 15117 15143 +26
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ximinez
added a commit
that referenced
this pull request
Aug 18, 2025
…actoring-1 * XRPLF/develop: fix: Modify jobs to use '>>' instead of 'tee' for GITHUB_OUTPUT (#5699) refactor: Revamp CI workflows (#5661) refactor: Decouple net from xrpld and move rpc-related classes to the rpc folder (#5477) Set version to 2.6.0-rc2 docs: Updates list of maintainers and reviewers (#5687) fix: Change log to debug level for AMM offer retrieval and IOU payment check (#5686) fix: Add -Wno-deprecated-declarations for Clang only (#5680) Update .git-blame-ignore-revs for #5657 (#5675) Fix BUILD.md instruction (#5676) Set version to 2.6.0-rc1 fix: Improve logging of the reason to refuse a peer connection (#5664) fix: Make test suite names match the directory name (#5597) chore: Run prettier on all files (#5657) chore: Set CONAN_REMOTE_URL also for forks (#5662) chore: Cleanup bin/ directory (#5660) perf: Optimize hash performance by avoiding allocating hash state object (#5469)
ximinez
added a commit
that referenced
this pull request
Aug 18, 2025
…to ximinez/lending-XLS-66 * XRPLF/ximinez/lending-refactoring-4: fix: Modify jobs to use '>>' instead of 'tee' for GITHUB_OUTPUT (#5699) refactor: Revamp CI workflows (#5661) refactor: Decouple net from xrpld and move rpc-related classes to the rpc folder (#5477) Set version to 2.6.0-rc2 docs: Updates list of maintainers and reviewers (#5687) fix: Change log to debug level for AMM offer retrieval and IOU payment check (#5686) fix: Add -Wno-deprecated-declarations for Clang only (#5680) Update .git-blame-ignore-revs for #5657 (#5675) Fix BUILD.md instruction (#5676) Set version to 2.6.0-rc1 fix: Improve logging of the reason to refuse a peer connection (#5664) fix: Make test suite names match the directory name (#5597) chore: Run prettier on all files (#5657) chore: Set CONAN_REMOTE_URL also for forks (#5662) chore: Cleanup bin/ directory (#5660) perf: Optimize hash performance by avoiding allocating hash state object (#5469)
yinyiqian1
pushed a commit
to yinyiqian1/rippled
that referenced
this pull request
Aug 20, 2025
…t check (XRPLF#5686) Reduce log noise by changing two log statements from error/warn level to debug level. These logs occur during normal operation when AMM offers are not available or when IOU authorization checks fail, which are expected scenarios that don't require an elevated log level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Reduce log noise by changing two log statements from error/warn level to debug level. These logs occur during normal operation when AMM offers are not available or when IOU authorization checks fail, which are expected scenarios that don't require an elevated log level.
Context of Change
During normal path-finding operations, the following scenarios frequently occur and generate unnecessary error/warning logs:
These situations are not errors but expected behaviors during path-finding. The excessive logging at error/warn levels creates noise in production logs, making it harder to identify actual issues.
Type of Change
API Impact