Removed unused code after flow cross retirement #5575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvysokikh1
commented
Jul 17, 2025
| Sandbox& sbCancel, | ||
| Amounts const& takerAmount, | ||
| std::optional<uint256> const& domainID) | ||
| { |
There was a problem hiding this comment.
According to the comment in CreateOffer.h, this function was temporary to invoke the different implementations of cross. Since we only have flow cross now, I'm removing this function and placing it's implementation directly where it was previously called.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5575 +/- ##
=========================================
+ Coverage 78.4% 78.8% +0.4%
=========================================
Files 816 814 -2
Lines 71730 71164 -566
Branches 8600 8332 -268
=========================================
- Hits 56234 56069 -165
+ Misses 15496 15095 -401
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Bronek
reviewed
Jul 21, 2025
bthomee
approved these changes
Jul 23, 2025
ximinez
added a commit
that referenced
this pull request
Jul 24, 2025
…to ximinez/lending-refactoring-3 * XRPLF/ximinez/lending-refactoring-2: refactor: Update rocksdb (#5568) Switch instrumentation workflow to use dependencies (#5607) chore: Rename conan profile to `default` (#5599) Include `network_id` in validations and subscription stream responses (#5579) Add support for `DomainID` in `MPTokenIssuance` transactions (#5509) chore: Remove unused code after flow cross retirement (#5575) Remove obsolete owner pays fee feature and XRPL_ABANDON stanza (#5550) refactor: Makes HashRouter flags more type-safe (#5371) Fix clang-format CI job (#5598)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
After FlowCross amendment retirement (#5562), there was still some unused code left. After going deeper into that, found out we could remove Taker class completely, since it was never used anywhere outside of direct/bridged cross.
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)