Skip to content

Trying to fix gcc-12 errors #5560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 14, 2025
Merged

Trying to fix gcc-12 errors #5560

merged 14 commits into from
Jul 14, 2025

Conversation

Bronek
Copy link
Collaborator

@Bronek Bronek commented Jul 14, 2025

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@codecov Codecov
Copy link

codecov bot commented Jul 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.0%. Comparing base (371834f) to head (6ee199e).
Report is 1 commits behind head on legleux/conan2.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           legleux/conan2   #5560     +/-   ##
================================================
- Coverage            79.0%   79.0%   -0.0%     
================================================
  Files                 816     816             
  Lines               71751   71751             
  Branches             8322    8325      +3     
================================================
- Hits                56668   56660      -8     
- Misses              15083   15091      +8

see 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Bronek
Copy link
Collaborator Author

Bronek commented Jul 14, 2025

@legleux can you pls merge this branch into your #5556 ? Just pls make sure to use squash merge.

Re. Windows workarounds, we will hopefully find something more appropriate at later time. For now, I just want the Linux builds to use the default profile which is defined in the build image, because it has the workarounds specific for the compiler in this image - including the ones needed to fix gcc-12 builds.

@Bronek Bronek mentioned this pull request Jul 14, 2025
Merged
2 tasks
@bthomee bthomee merged commit f6358a7 into legleux/conan2 Jul 14, 2025
27 checks passed
@bthomee bthomee deleted the Bronek/conan2 branch July 14, 2025 16:09
legleux pushed a commit that referenced this pull request Jul 14, 2025
@Bronek @legleux
Trying to fix gcc-12 errors (#5560)
2e5ecf8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bronek @bthomee