fix DeliveredAmount and delivered_amount in transaction metadata for direct MPT transfer
#5569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5569 +/- ##
=======================================
Coverage 78.8% 78.8%
=======================================
Files 814 814
Lines 71258 71262 +4
Branches 8366 8349 -17
=======================================
+ Hits 56133 56158 +25
+ Misses 15125 15104 -21
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
yinyiqian1
approved these changes
Jul 28, 2025
DeliveredAmount and delievered_amount in transaction metadata for direct MPT transferDeliveredAmount and delivered_amount in transaction metadata for direct MPT transfer
ximinez
added a commit
that referenced
this pull request
Jul 30, 2025
…to ximinez/lending-XLS-66 * XRPLF/ximinez/lending-refactoring-4: fix `DeliveredAmount` and `delivered_amount` in transaction metadata for direct MPT transfer (#5569)
bthomee
pushed a commit
that referenced
this pull request
Jul 31, 2025
…for direct MPT transfer (#5569) The Payment transaction metadata is missing the `DeliveredAmount` field that displays the actual amount delivered to the destination excluding transfer fees. This amendment fixes this problem.
mvadari
pushed a commit
to mvadari/rippled
that referenced
this pull request
Aug 5, 2025
…for direct MPT transfer (XRPLF#5569) The Payment transaction metadata is missing the `DeliveredAmount` field that displays the actual amount delivered to the destination excluding transfer fees. This amendment fixes this problem.
Merged
|
@shawnxie999 would you like to create a new PR to switch |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The Payment transaction metadata is missing the
DeliveredAmountfield that displays the actual amount delivered to the destination excluding transfer fees. This amendment fixes this problem.Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)