-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Decouple ledger from xrpld/app #5492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5492 +/- ##
=========================================
- Coverage 78.8% 78.8% -0.0%
=========================================
Files 814 814
Lines 71270 71269 -1
Branches 8343 8348 +5
=========================================
- Hits 56172 56159 -13
- Misses 15098 15110 +12
🚀 New features to boost your workflow:
|
vvysokikh1
reviewed
Jul 21, 2025
yinyiqian1
reviewed
Jul 28, 2025
Signed-off-by: JCW <[email protected]>
Signed-off-by: JCW <[email protected]>
yinyiqian1
approved these changes
Aug 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
vvysokikh1
approved these changes
Aug 5, 2025
mvadari
pushed a commit
to mvadari/rippled
that referenced
this pull request
Aug 5, 2025
This change decouples `ledger` from `xrpld/app`, and therefore fully clears the path to the modularisation of the ledger component. Before this change, `View.cpp` relied on `MPTokenAuthorize::authorize; this change moves `MPTokenAuthorize::authorize` to `View.cpp` to invert the dependency, making ledger a standalone module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ready to merge
*PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR decouples ledger from xrpld/app, and therefore fully clears the path to the modularisation of the ledger component.
Context of Change
Before this change,
View.cpp
relies onMPTokenAuthorize::authorize
, and this change movesMPTokenAuthorize::authorize
toView.cpp
to invert the dependency, makingledger
a standalone module.Type of Change
.gitignore
, formatting, dropping support for older tooling)API Impact
This change doesn't affect any API
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)Test Plan
As usual, regression test just for our sanity
Future Tasks
Modularise
ledger