fix: improve multisign usage of simulate
#5479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5479 +/- ##
=======================================
Coverage 79.1% 79.1%
=======================================
Files 817 817
Lines 71700 71703 +3
Branches 8257 8241 -16
=======================================
+ Hits 56692 56711 +19
+ Misses 15008 14992 -16
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Bronek
approved these changes
Jun 6, 2025
|
@Bronek you may want to re-review, I found another issue when refactoring (you could simulate a transaction that was both single- and multi-"signed") |
Bronek
approved these changes
Jun 6, 2025
oleks-rip
reviewed
Jun 6, 2025
oleks-rip
reviewed
Jun 6, 2025
intelliot
approved these changes
Jun 7, 2025
oleks-rip
approved these changes
Jun 9, 2025
This was referenced Jun 12, 2025
Merged
Closed
Closed
Merged
yinyiqian1
pushed a commit
to yinyiqian1/rippled
that referenced
this pull request
Jul 5, 2025
This change allows users to submit simulate requests from a multi-sign account without needing to specify the accounts that are doing the multi-signing, and fixes an error with simulate that allowed double-"signed" (both single-sign and multi-sign public keys are provided) transactions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR allows users to submit
simulaterequests from a multisign account without needing to specify the accounts that are doing the multisigning, and fixes an error withsimulatethat allowed double-"signed" (both single-sign and multi-sign public keys are provided) transactions.Context of Change
There was some confusion about how to use
simulatewith a multisign account. ReceivingtefMASTER_DISABLEDwas unexpected. This change makes it more intuitive.Type of Change
API Impact
Before / After
Before:
Submitting a
simulaterequest for a transaction from an account with the master key disabled and a multisig setup would result intefMASTER_DISABLED.You can submit a
simulaterequest with bothSigningPubKeyandSigners.After:
Submitting a
simulaterequest for a transaction from an account with the master key disabled and a multisig setup ignores signature checking completely (unlessSignersis provided in any way, shape, or form).Submitting a
simulaterequest with bothSigningPubKeyandSignersresults intemINVALID.Test Plan
Tests were adjusted and CI passes.